Skip to content

Einsum OpenVINO backend#25291

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
dkurt:einsum_openvino
Mar 29, 2024
Merged

Einsum OpenVINO backend#25291
asmorkalov merged 1 commit intoopencv:4.xfrom
dkurt:einsum_openvino

Conversation

@dkurt
Copy link
Copy Markdown
Member

@dkurt dkurt commented Mar 29, 2024

Pull Request Readiness Checklist

On skipped tests:

[ RUN      ] Test_ONNX_layers.Einsum_2D_Ellipses/0, where GetParam() = NGRAPH/CPU
unknown file: Failure
C++ exception with description "Check 'input_rank >= labels.size()' failed at src/core/shape_inference/include/einsum_shape_inference.hpp:41:
While validating node 'opset7::Einsum Einsum_2190 (0.0[0]:f32[4,5], 1.1[0]:f32[5,8]) -> (dynamic[...])' with friendly_name 'Einsum_2190':
Input rank must be greater or equal to a number of labels in the corresponding input subscript.
" thrown in the test body.
[  FAILED  ] Test_ONNX_layers.Einsum_2D_Ellipses/0, where GetParam() = NGRAPH/CPU (0 ms)

[ RUN      ] Test_ONNX_layers.Einsum_Batch_Diagonal/0, where GetParam() = NGRAPH/CPU
unknown file: Failure
C++ exception with description "OpenCV(4.9.0-dev) /home/dkurtaev/opencv/modules/dnn/src/ie_ngraph.cpp:369: error: (-2:Unspecified error) in function 'initPlugin'
> Failed to initialize Inference Engine backend (device = CPU): Exception from src/inference/src/core.cpp:113:
> [ GENERAL_ERROR ] Unsupported operation of type: Einsum name: 1
> Details:
> Cannot fallback on ngraph reference implementation (Ngraph::Node::evaluate() is not implemented)
> " thrown in the test body.
[  FAILED  ] Test_ONNX_layers.Einsum_Batch_Diagonal/0, where GetParam() = NGRAPH/CPU (2 ms)

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@dkurt dkurt requested a review from Abdurrahheem March 29, 2024 07:08
@dkurt dkurt force-pushed the einsum_openvino branch from 5e5bd11 to 2928ce4 Compare March 29, 2024 07:30
asmorkalov
asmorkalov approved these changes Mar 29, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov self-requested a review March 29, 2024 08:22
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Mar 29, 2024

Another failed test on CI:

 [ RUN      ] Test_ONNX_conformance.Layer_Test/test_einsum_batch_diagonal_NGRAPH_CPU, where GetParam() = (test_einsum_batch_diagonal, NGRAPH/CPU)
Exception during net.forward() call!
unknown file: Failure
C++ exception with description "OpenCV(4.9.0-dev) /home/openvino/opencv/modules/dnn/src/ie_ngraph.cpp:369: error: (-2:Unspecified error) in function 'initPlugin'
> Failed to initialize Inference Engine backend (device = CPU): Check 'false' failed at src/inference/src/core.cpp:114:
> Unsupported operation of type: Einsum name: y
> Details:
> Cannot fallback on ngraph reference implementation (Ngraph::Node::evaluate() is not implemented)
> " thrown in the test body.
[  FAILED  ] Test_ONNX_conformance.Layer_Test/test_einsum_batch_diagonal_NGRAPH_CPU, where GetParam() = (test_einsum_batch_diagonal, NGRAPH/CPU) (8 ms)

@asmorkalov asmorkalov added this to the 4.10.0 milestone Mar 29, 2024
@dkurt dkurt force-pushed the einsum_openvino branch from 2928ce4 to cfa42e4 Compare March 29, 2024 11:29
asmorkalov
asmorkalov approved these changes Mar 29, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 9fc4b61 into opencv:4.x Mar 29, 2024
@dkurt dkurt deleted the einsum_openvino branch March 29, 2024 12:55
@asmorkalov asmorkalov mentioned this pull request Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@Abdurrahheem Abdurrahheem Awaiting requested review from Abdurrahheem

Assignees

No one assigned

Labels

category: dnn optimization

Projects

None yet

Milestone

4.10.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dkurt @asmorkalov