Fix detect rotated SYMMETRIC_GRID#25258
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Mar 26, 2024
Merged
Conversation
13e6430 to
3f999b4
Compare
asmorkalov
reviewed
Mar 25, 2024
3f999b4 to
eaa88e7
Compare
asmorkalov
approved these changes
Mar 26, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge with opencv/opencv_extra#1157
Fixes #24964
This PR fixes
isDetectionCorrect()infindCirclesGrid()for SYMMETRIC_GRID.To
isDetectionCorrect()added check rotation of the grid and bool flagrotatedGrid. ifrotatedGridis true,getHoles()transpose the circle grid before return.Detect pattern with Size(7, 6):

Detect pattern with Size(6, 7):

Tests in benchmark with params


--configuration=generate_run --board_x=7 --board_y=6 --path=res_circle --synthetic_object=circle_sym_grid:before fix:
after fix:
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.