Skip to content

Fix for jpegturbo Windows build#25229

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
giokara-work:fix_jpegturbo_win64
Mar 20, 2024
Merged

Fix for jpegturbo Windows build#25229
opencv-pushbot merged 1 commit intoopencv:4.xfrom
giokara-work:fix_jpegturbo_win64

Conversation

@giokara-work
Copy link
Copy Markdown
Contributor

@giokara-work giokara-work commented Mar 18, 2024

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@opencv-alalek opencv-alalek added this to the 4.10.0 milestone Mar 18, 2024
@mshabunin
Copy link
Copy Markdown
Contributor

mshabunin commented Mar 19, 2024

Could you please add more details: platform info, steps to reproduce, error message...

opencv-alalek
opencv-alalek approved these changes Mar 20, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@opencv-alalek opencv-alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@opencv-alalek opencv-alalek self-assigned this Mar 20, 2024
@opencv-pushbot opencv-pushbot merged commit 3aefd48 into opencv:4.x Mar 20, 2024
@giokara-work
Copy link
Copy Markdown
Contributor Author

giokara-work commented Mar 20, 2024 •
edited
Loading

Could you please add more details: platform info, steps to reproduce, error message...

It seems this is only an issue when running cmake through Bazel build system, as we are doing. In that case CMAKE_SYSTEM_PROCESSOR is unset on Windows which breaks the jpegturbo build. So this is more a workaround.

See also bazel-contrib/rules_foreign_cc#869.

@giokara-work giokara-work deleted the fix_jpegturbo_win64 branch March 22, 2024 10:20
@asmorkalov asmorkalov mentioned this pull request Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opencv-alalek opencv-alalek opencv-alalek approved these changes

Assignees

@opencv-alalek opencv-alalek

Labels

category: build/install category: 3rdparty

Projects

None yet

Milestone

4.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@giokara-work @mshabunin @opencv-alalek @opencv-pushbot