Skip to content

Fix bug in maskBoundingRect#25183

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
MaximSmolskiy:fix-bug-in-maskBoundingRect
Mar 27, 2024
Merged

Fix bug in maskBoundingRect#25183
asmorkalov merged 1 commit intoopencv:4.xfrom
MaximSmolskiy:fix-bug-in-maskBoundingRect

Conversation

@MaximSmolskiy
Copy link
Copy Markdown
Contributor

Pull Request Readiness Checklist

Fix #24217

Issue bug is reproduced when for filled row offset == size.width
We fully processed this row only in one loop and didn't go to branch offset < size.width
Problem was in that we were breaking out of loop after first non-zero value and thus couldn't update properly xmax value

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks a lot for the good catch! The issue and fix is not obvious.

@asmorkalov asmorkalov merged commit d664d8d into opencv:4.x Mar 27, 2024
@asmorkalov asmorkalov self-assigned this Mar 27, 2024
@MaximSmolskiy MaximSmolskiy deleted the fix-bug-in-maskBoundingRect branch March 27, 2024 07:01
@asmorkalov asmorkalov mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

boundingRect returns incorrect result for mask with some image/shape combinations

2 participants