Skip to content

upgrade libwebp to version 1.3.2#25097

Closed
klatism wants to merge 2 commits intoopencv:4.xfrom
klatism:webp-upgrade
Closed

upgrade libwebp to version 1.3.2#25097
klatism wants to merge 2 commits intoopencv:4.xfrom
klatism:webp-upgrade

Conversation

@klatism
Copy link
Copy Markdown
Contributor

@klatism klatism commented Feb 26, 2024

upgrade libwebp from version 1.2.0 to 1.3.2

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.10.0 milestone Feb 26, 2024
@klatism klatism mentioned this pull request Feb 26, 2024
Closed
6 tasks
@asmorkalov asmorkalov requested a review from vrabaud February 27, 2024 11:44
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Feb 27, 2024

/cc @vrabaud

@vrabaud
Copy link
Copy Markdown
Contributor

vrabaud commented Feb 27, 2024

Hi, I am one of the WebP developers. The version I last updated in 3rdparty is actually from main, after 1.3.2 was tagged, it is this commit: https://chromium.googlesource.com/webm/libwebp/+log/c1ffd9ac7593894c40a1de99d03f0b7af8af2577

It contains all fixes from 1.3.2 (especially security fixes) as well as whatever was done in main (which is not much but that includes some [[no_discard]] fixes for example). So I'd recommend keeping that version.

1.4.x will be branched from main this quarter so we might as well wait for it.

BTW, I believe we only include in 3rdparty what is strictly necessary (e.g. no Makefile, CHANGELOG ...), is that right @asmorkalov ?

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Feb 27, 2024

@vrabaud Thanks!
About including new files - yes.
About current version - ok let's wait for 1.4.

@asmorkalov asmorkalov closed this Feb 27, 2024
@vrabaud vrabaud mentioned this pull request Apr 17, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vrabaud vrabaud Awaiting requested review from vrabaud

Assignees

No one assigned

Labels

category: 3rdparty

Projects

None yet

Milestone

4.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@klatism @asmorkalov @vrabaud