Disable fp16 instructions detection on Windows ARM64 because of build issues#25069
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Feb 28, 2024
Merged
Conversation
Contributor
Author
|
/cc @tomoaki0705 |
Contributor
Author
|
@opencv-alalek May I merge this? |
Contributor
Author
|
/cc @vpisarev |
Contributor
|
@asmorkalov, CV_FP16 is quite important feature and will be even more important in the new dnn and imgproc modules. If I understand correctly, we correctly detect ARM Neon on Windows. CV_FP16 (unlike CV_NEON_FP16) is a subset of CV_NEON. Therefore, on Windows@ARM systems we need to change the check for CV_FP16 with the check for CV_FP16+CV_NEON. |
Contributor
Author
|
The issue is that most of branches with f16 on Windows are implemented for x86. We need to revise all of them and fix. The idea of the patch -disable fp16 for now to unblock default configuration build. You are welcome to fix fp16 for ARM Windows. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #25052
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.