Skip to content

Adds missing const in function declaration of VideoCapture#25062

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
TinyTinni:missing-const
Feb 22, 2024
Merged

Adds missing const in function declaration of VideoCapture#25062
asmorkalov merged 1 commit intoopencv:4.xfrom
TinyTinni:missing-const

Conversation

@TinyTinni
Copy link
Copy Markdown
Contributor

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Hi,
I stumbled over this function declaration.
I think a const declaration was just forgotten here.

This MR just adds it.
It is in theory a interface change, but it does not break backward compatibility, does not restrict the usage of it. It just enhances the possibilities, where the funtion can be called (with const VideoCapture&)

Greetings

@TinyTinni
Copy link
Copy Markdown
Contributor Author

CI builds failed. Doesn't seem compiler related. As this is the only step this minifix can break the CI, a retry should solve the problem.

Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov added this to the 4.10.0 milestone Feb 22, 2024
@asmorkalov asmorkalov merged commit 296a90a into opencv:4.x Feb 22, 2024
@asmorkalov asmorkalov mentioned this pull request Feb 26, 2024
@TinyTinni TinyTinni deleted the missing-const branch August 17, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants