RegisterCameras function for heterogenious cameras pair#25061
Merged
asmorkalov merged 2 commits intoopencv:5.xfrom Feb 26, 2024
Merged
RegisterCameras function for heterogenious cameras pair#25061asmorkalov merged 2 commits intoopencv:5.xfrom
asmorkalov merged 2 commits intoopencv:5.xfrom
Conversation
Contributor
Author
5bb3e57 to
11b4e6c
Compare
11b4e6c to
53dd3cf
Compare
Contributor
Author
|
cc @catree |
vpisarev
reviewed
Feb 25, 2024
vpisarev
reviewed
Feb 25, 2024
|
|
||
| ///////////////////////////////// Register Cameras //////////////////////////////////////////////// | ||
|
|
||
| class CV_CameraRegistrationTest : public cvtest::BaseTest |
Contributor
There was a problem hiding this comment.
Most of the test are written in old style; perhaps, need to rewrite them in GTest-style sometimes, but it's not urgent, of course
vpisarev
reviewed
Feb 25, 2024
| J_LR.at<double>(p, 3+j) = de3dt2(j); | ||
| } | ||
|
|
||
| JtJ(Rect(0, 0, 6, 6)) += J_LR.t()*J_LR; |
Contributor
There was a problem hiding this comment.
btw, all such code would have to be rewritten if we get rid of matrix expressions; probably, it's easier to keep it (matrix expressions and this code)
vpisarev
approved these changes
Feb 25, 2024
53dd3cf to
be4bca2
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credits to Linfei Pan
Extracted from #24052
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.