Skip to content

core: fix float16_t optimization condition#25059

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
opencv-pushbot:gitee/alalek/core_fix_float16
Feb 24, 2024
Merged

core: fix float16_t optimization condition#25059
asmorkalov merged 1 commit intoopencv:4.xfrom
opencv-pushbot:gitee/alalek/core_fix_float16

Conversation

@opencv-alalek
Copy link
Copy Markdown
Contributor

@opencv-alalek opencv-alalek commented Feb 21, 2024

  • resolves issue on Windows ARM64

relates #25052

relates #18782

- resolves issue on Windows ARM64
@asmorkalov
Copy link
Copy Markdown
Contributor

@opencv-alalek Unfortunatelly it's not enough. There are a lot of other FP16 issues in intrin_neon.hpp and some other places. I close the PR for now till complete solution for Windows.

@asmorkalov asmorkalov closed this Feb 21, 2024
@opencv-alalek
Copy link
Copy Markdown
Contributor Author

Fix is not enough, but it is correct.
We should not run AVX2 intrinsics on non-AVX2 platforms.

@asmorkalov asmorkalov reopened this Feb 21, 2024
@asmorkalov asmorkalov self-requested a review February 22, 2024 10:19
@asmorkalov asmorkalov self-assigned this Feb 22, 2024
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit a2e23fa into opencv:4.x Feb 24, 2024
@asmorkalov asmorkalov mentioned this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants