G-API: Ifdef OpenVINO API 1.0 functionality#24878
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Jan 18, 2024
Merged
Conversation
TolyaTalamanov
commented
Jan 17, 2024
| #include "backends/ie/giebackend.hpp" | ||
|
|
||
| #ifdef HAVE_INF_ENGINE | ||
| #if defined HAVE_INF_ENGINE && INF_ENGINE_RELEASE < 2024000000 |
Contributor
Author
There was a problem hiding this comment.
Does it make since to introduce HAVE_OPENVINO for versions GE than 2022.1 and set HAVE_INF_ENGINE to false for versions GE 2024.0? In that case ifdef HAVE_INF_ENGINE would be enough.
dmatveev
approved these changes
Jan 17, 2024
smirnov-alexey
approved these changes
Jan 17, 2024
AsyaPronina
approved these changes
Jan 17, 2024
Contributor
Author
|
@asmorkalov Could you merge this, please? |
4 tasks
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
OpenVINO introduced the new
API 2.0since2022.1.0version and plan to completely remove the old API by2024.0.0.The suggestion is to check
INF_ENGINE_RELEASE < 2024000000and if so, completely disableIEbackend and its unit tests that rely onAPI 1.0.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.