Orbbec Camera supports MacOS，Gemini2 and Gemini2L support Y16 format by zzuliys · Pull Request #24877 · opencv/opencv

zzuliys · 2024-01-17T12:35:10Z

note:
1.Gemini2 and Gemini2L must use the latest firmware -- https://github.com/orbbec/OrbbecFirmware;
2.Administrator privileges are necessary to run on MacOS.

3rdparty/orbbecsdk/orbbecsdk.cmake

modules/videoio/src/cap_obsensor/obsensor_uvc_stream_channel.cpp

modules/videoio/src/cap_obsensor_capture.cpp

fengyuentau · 2024-01-23T06:10:46Z

The only concern on my side is the sdk is needed if using the orbbec cameras on macOS. In this case how do we distribute prebuilt packages with this feature enable?

CMakeLists.txt

modules/videoio/src/cap_obsensor_capture.cpp

modules/videoio/src/cap_obsensor/obsensor_uvc_stream_channel.cpp

fengyuentau · 2024-01-25T07:58:33Z

Reminder of CI complains:

# Doc
modules/videoio/CMakeLists.txt:240: trailing whitespace.
+    list(APPEND videoio_srcs 

# Build warnings
C:\build\precommit_windows64\4.x\opencv\modules\videoio\src\cap_obsensor\obsensor_uvc_stream_channel.cpp(320): warning C4305: '=': truncation from 'double' to 'float' [C:\build\precommit_windows64\build\modules\videoio\opencv_videoio.vcxproj]
C:\build\precommit_windows64\4.x\opencv\modules\videoio\src\cap_obsensor\obsensor_uvc_stream_channel.cpp(323): warning C4305: '=': truncation from 'double' to 'float' [C:\build\precommit_windows64\build\modules\videoio\opencv_videoio.vcxproj]

modules/videoio/cmake/detect_obsensor.cmake

kaingwade · 2024-01-29T09:39:41Z

Orbbec UVC cameras now works on MacOS.

But there is the concern as @fengyuentau mentioned earlier:

The only concern on my side is the sdk is needed if using the orbbec cameras on macOS. In this case how do we distribute prebuilt packages with this feature enable?

zzuliys · 2024-01-29T09:53:09Z

Orbbec UVC cameras now works on MacOS.

But there is the concern as @fengyuentau mentioned earlier:

The only concern on my side is the sdk is needed if using the orbbec cameras on macOS. In this case how do we distribute prebuilt packages with this feature enable?

I'm sorry to inform you that currently, on MacOS, the Orbbec camera can only be implemented using this method.

modules/videoio/cmake/detect_obsensor.cmake

fengyuentau

👍 I propose to merge it for now and there should be a subsequent PR providing another build option which detects and uses the pre-installed libOrbbec instead of downloading it every time.

kaingwade · 2024-02-28T02:30:01Z

@asmorkalov Can the PR be merged as it is for now

CMakeLists.txt

modules/videoio/src/cap_obsensor_capture.cpp

zzuliys · 2024-03-25T07:02:48Z

@asmorkalov I see that you haven't raised any new questions for a long time, and all the issues you previously raised have been resolved. We hope the code can be merged as soon as possible. Thank you.

modules/videoio/src/cap_obsensor/obsensor_uvc_stream_channel.cpp

CMakeLists.txt

asmorkalov · 2024-03-27T12:39:54Z

Looks good for me in general, besides minor remarks. CMake option to point external Orbbec SDK is required, but it could be done in dedicated PR as proposed.

zzuliys · 2024-03-28T02:53:16Z

@asmorkalov All the issues you have reported have been resolved

asmorkalov

👍

asmorkalov · 2024-03-28T06:57:43Z

@opencv-alalek Could you take a look?

opencv-alalek · 2024-03-30T08:10:43Z

@zzuliys Please take a look on #25298

zzuliys · 2024-04-01T02:35:54Z

@zzuliys Please take a look on #25298

https://github.com/opencv/opencv/pull/25301/files Sorry for my negligence. I have fixed this issue and you can test it out

Orbbec Camera supports MacOS，Gemini2 and Gemini2L support Y16 format opencv#24877 note: 1.Gemini2 and Gemini2L must use the latest firmware -- https://github.com/orbbec/OrbbecFirmware; 2.Administrator privileges are necessary to run on MacOS.

obwh and others added 4 commits January 17, 2024 18:29

add Orbbec 3d camera supported on MacOS (aarch64)

7499acb

adjust gemini2L deep stream format to Y16

15b2662

optimized code

e80a904

add Gemini2L support Y16

c4e0797

asmorkalov requested changes Jan 17, 2024

View reviewed changes

asmorkalov requested review from WanliZhong and fengyuentau January 17, 2024 13:05

asmorkalov added feature category: videoio(camera) labels Jan 17, 2024

daiyin and others added 3 commits January 18, 2024 10:39

MacOS defaults to disabling Orbbec cameras

aecdbdc

default support for Orbbec cameras under MacOS

5784b5c

resolve the issue of unable to find orbbecsdk

2236c9c

switch OrbbecSDK version to 1.9.4

efb2136

hzcyf reviewed Jan 25, 2024

View reviewed changes

fengyuentau reviewed Jan 25, 2024

View reviewed changes

modules/videoio/cmake/detect_obsensor.cmake Outdated Show resolved Hide resolved

obwh and others added 4 commits January 26, 2024 20:22

close OrbbecSDK log file generation

5e9f6d5

fix OrbbecSDK install path

ce09cfe

fix data conversion warning

4f07deb

delete redundant code

a6d79cb

opencv-alalek added the platform: ios/osx label Feb 2, 2024

opencv-alalek reviewed Feb 2, 2024

View reviewed changes

modules/videoio/cmake/detect_obsensor.cmake Show resolved Hide resolved

release orbbecsdk license

ea9cf86

fengyuentau approved these changes Feb 7, 2024

View reviewed changes

asmorkalov reviewed Feb 28, 2024

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

modules/videoio/src/cap_obsensor_capture.cpp Outdated Show resolved Hide resolved

optimize the naming of variables

c30ceec

asmorkalov reviewed Mar 27, 2024

View reviewed changes

modules/videoio/src/cap_obsensor/obsensor_uvc_stream_channel.cpp Show resolved Hide resolved

CMakeLists.txt Outdated Show resolved Hide resolved

support for X86_64 and X86

a2802f6

asmorkalov approved these changes Mar 28, 2024

View reviewed changes

asmorkalov merged commit 2b9d1a2 into opencv:4.x Mar 29, 2024

asmorkalov self-assigned this Mar 29, 2024

asmorkalov added this to the 4.10.0 milestone Mar 29, 2024

akretz mentioned this pull request Mar 29, 2024

OrbbecSDK md5 check fails #25298

Closed

4 tasks

asmorkalov mentioned this pull request Apr 1, 2024

5.x merge 4.x #25305

Merged

kaingwade mentioned this pull request Apr 9, 2024

Orbbec 3d cameras no longer work on Windows and Ubuntu #25376

Closed

4 tasks

aiusepsi mentioned this pull request Jun 3, 2024

On macOS linking to third-party Orbbec SDK binary by default #25693

Closed

4 tasks

kaingwade mentioned this pull request Aug 1, 2025

Added timestamps support for Orbbec SDK backend in VideoIO. #27610

Merged

6 tasks

Uh oh!

Conversation

zzuliys commented Jan 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fengyuentau commented Jan 23, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fengyuentau commented Jan 25, 2024

Uh oh!

Uh oh!

kaingwade commented Jan 29, 2024

Uh oh!

zzuliys commented Jan 29, 2024

Uh oh!

Uh oh!

fengyuentau left a comment

Choose a reason for hiding this comment

Uh oh!

kaingwade commented Feb 28, 2024

Uh oh!

Uh oh!

Uh oh!

zzuliys commented Mar 25, 2024

Uh oh!

Uh oh!

Uh oh!

asmorkalov commented Mar 27, 2024

Uh oh!

zzuliys commented Mar 28, 2024

Uh oh!

asmorkalov left a comment

Choose a reason for hiding this comment

Uh oh!

asmorkalov commented Mar 28, 2024

Uh oh!

opencv-alalek commented Mar 30, 2024

Uh oh!

zzuliys commented Apr 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

zzuliys commented Jan 17, 2024 •

edited

Loading