Skip to content

Fixed AndroidManifest.xml syntax in Android camerapreview sample#24874

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
alexlyulkov:al/fix-manifest-comments
Jan 17, 2024
Merged

Fixed AndroidManifest.xml syntax in Android camerapreview sample#24874
asmorkalov merged 1 commit intoopencv:4.xfrom
alexlyulkov:al/fix-manifest-comments

Conversation

@alexlyulkov
Copy link
Copy Markdown
Contributor

@alexlyulkov alexlyulkov commented Jan 17, 2024

Removed useless comments with incorrect syntax, because Android Studio shows warnings on them

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jan 17, 2024

It's an anchor for Doxygen documentation:

doc/tutorials/introduction/android_binary_package/dev_with_OCV_on_Android.markdown:162:    @snippet samples/android/tutorial-1-camerapreview/gradle/AndroidManifest.xml camera_permissions

Looks like we should re-format it to be XML and Doxygen compatible.

@asmorkalov asmorkalov force-pushed the al/fix-manifest-comments branch from 8a2049f to a865fd6 Compare January 17, 2024 10:28
asmorkalov
asmorkalov approved these changes Jan 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov added this to the 4.10.0 milestone Jan 17, 2024
@asmorkalov asmorkalov self-assigned this Jan 17, 2024
@asmorkalov asmorkalov merged commit b647e65 into opencv:4.x Jan 17, 2024
@asmorkalov asmorkalov mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: build/install category: documentation Documentation fix or update

Projects

None yet

Milestone

4.10.0

Development

Successfully merging this pull request may close these issues.

2 participants

@alexlyulkov @asmorkalov