Skip to content

Normalize axis parameter in DNN Concat to handle negative values#24865

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/dnn_concat_assert
Jan 16, 2024
Merged

Normalize axis parameter in DNN Concat to handle negative values#24865
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/dnn_concat_assert

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Jan 16, 2024 •
edited
Loading

Fixes #24861

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added the category: dnn (onnx) ONNX suport issues in DNN module label Jan 16, 2024
@asmorkalov asmorkalov added this to the 4.10.0 milestone Jan 16, 2024
dkurt
dkurt reviewed Jan 16, 2024
View reviewed changes
@asmorkalov asmorkalov force-pushed the as/dnn_concat_assert branch from 310c075 to 26cf82a Compare January 16, 2024 09:23
@asmorkalov asmorkalov changed the title Do not allow ONNX Concat with negative axis value for now Normalize axis parameter in DNN Concat to handle negative values Jan 16, 2024
@asmorkalov asmorkalov mentioned this pull request Jan 16, 2024
Merged
6 tasks
@dkurt
Copy link
Copy Markdown
Member

dkurt commented Jan 16, 2024

Unrelated test failed: https://github.com/opencv/opencv/actions/runs/7539494151/job/20522116481?pr=24865

 [ RUN      ] stitchExposureCompMultiFeed_a123.a123/13, where GetParam() = ("blocks_gain", 4)
/Users/opencv-cn/GHA-OCV-2/_work/_temp/df6633ee-081f-4265-b914-eeabe0feac7a.sh: line 1: 12512 Abort trap: 6           ./bin/opencv_perf_stitching --perf_impl=plain --perf_min_samples=1 --perf_force_samples=1 --perf_verify_sanity --skip_unstable=1 --perf_threads=$PARALLEL_JOBS

@asmorkalov asmorkalov merged commit 84bb1cd into opencv:4.x Jan 16, 2024
@asmorkalov asmorkalov mentioned this pull request Jan 23, 2024
Merged
@asmorkalov asmorkalov mentioned this pull request Feb 7, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt approved these changes

@fengyuentau fengyuentau Awaiting requested review from fengyuentau

Assignees

No one assigned

Labels

category: dnn (onnx) ONNX suport issues in DNN module

Projects

None yet

Milestone

4.10.0

Development

Successfully merging this pull request may close these issues.

OpenCV DNN does not support Concat with negative axis value

3 participants

@asmorkalov @dkurt @fengyuentau