Make \epsilon parameter accessible in VariationalRefinement#24852
Merged
asmorkalov merged 4 commits intoopencv:4.xfrom Jan 17, 2024
Burnside999:4.x
Merged
Make \epsilon parameter accessible in VariationalRefinement#24852asmorkalov merged 4 commits intoopencv:4.xfrom Burnside999:4.x
asmorkalov merged 4 commits intoopencv:4.xfrom
Burnside999:4.x
Conversation
Contributor
|
@opencv-alalek could you tune ABI checker configuration. |
asmorkalov
reviewed
Jan 12, 2024
|
It would be great to add this parameter to dis_flow.cpp float getVariationalRefinementEpsilon() const CV_OVERRIDE { return variational_refinement_epsilon; }
void setVariationalRefinementEpsilon(float val) CV_OVERRIDE { variational_refinement_epsilon = val; }and variational_refinement_processors[i]->setEpsilon(variational_refinement_epsilon);and in tracking.hpp /** @brief Charbonier Robust metric term
@see setVariationalRefinementEpsilon */
CV_WRAP virtual float getVariationalRefinementEpsilon() const = 0;
/** @copybrief getVariationalRefinementEpsilon @see getVariationalRefinementEpsilon */
CV_WRAP virtual void setVariationalRefinementEpsilon(float val) = 0;Or may be it is better to create an other issue ? |
Contributor
Author
Perhaps there's no need to open a new issue; I have already attempted to make the necessary modifications. |
Contributor
Author
|
I apologize as this is my first attempt to submit a pr to opencv, and I lack some experience. Why this workflow is stuck? How should I proceed to resolve it? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #24847
I believe this is necessary to expose \epsilon parameter.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.