Skip to content

Manage Python Limited API version externally#24837

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/python_limited_api_version
Jan 12, 2024
Merged

Manage Python Limited API version externally#24837
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/python_limited_api_version

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Jan 9, 2024 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.10.0 milestone Jan 9, 2024
@asmorkalov asmorkalov mentioned this pull request Jan 9, 2024
Merged
6 tasks
opencv-alalek
opencv-alalek reviewed Jan 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@opencv-alalek opencv-alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, the main case of Limited API when we need to support prior python versions.

At least we need to make that configurable or just increment used version.

@asmorkalov asmorkalov force-pushed the as/python_limited_api_version branch from b7a2146 to a0e7e29 Compare January 9, 2024 16:46
@asmorkalov asmorkalov changed the title Use current Python version in case of LIMITED_API enabled. Manage Python Limited API version externally Jan 9, 2024
@asmorkalov asmorkalov force-pushed the as/python_limited_api_version branch from a0e7e29 to 7852ef2 Compare January 9, 2024 16:47
@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Jan 9, 2024

@opencv-alalek I extracted Limited API version as CMake option and added it to CMake status page.

mshabunin
mshabunin reviewed Jan 9, 2024
View reviewed changes
@asmorkalov asmorkalov force-pushed the as/python_limited_api_version branch from 7852ef2 to 2beacc0 Compare January 10, 2024 09:30
mshabunin
mshabunin approved these changes Jan 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mshabunin mshabunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though I can not check it with older NumPy right now.

@asmorkalov asmorkalov merged commit 1bde621 into opencv:4.x Jan 12, 2024
This was referenced Jan 19, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opencv-alalek opencv-alalek opencv-alalek left review comments

@mshabunin mshabunin mshabunin approved these changes

@VadimLevin VadimLevin Awaiting requested review from VadimLevin

Assignees

No one assigned

Labels

category: python bindings

Projects

None yet

Milestone

4.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@asmorkalov @mshabunin @opencv-alalek