Skip to content

Resolved issue number #22177#24832

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
AryanNanda17:Aryan#22177
Jan 26, 2024
Merged

Resolved issue number #22177#24832
asmorkalov merged 1 commit intoopencv:4.xfrom
AryanNanda17:Aryan#22177

Conversation

@AryanNanda17
Copy link
Copy Markdown
Contributor

@AryanNanda17 AryanNanda17 commented Jan 8, 2024 •
edited by asmorkalov
Loading

Resolved issue no #22177

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@AryanNanda17
Copy link
Copy Markdown
Contributor Author

AryanNanda17 commented Jan 8, 2024

Resolved issue no #22177

asmorkalov
asmorkalov reviewed Jan 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constants are used not only by remap, but many other functions like warpAfine, warpPerspective, blur, etc. The behaviour should be checked everywhere.

@AryanNanda17
Copy link
Copy Markdown
Contributor Author

AryanNanda17 commented Jan 9, 2024

Alright!
I will verify and ensure that these changes don't disrupt the expected behavior in functions beyond just remap().

@AryanNanda17
Copy link
Copy Markdown
Contributor Author

AryanNanda17 commented Jan 9, 2024

I checked the behavior and it is not causing any trouble. What should I do next @asmorkalov.

@opencv-alalek opencv-alalek added the category: documentation Documentation fix or update label Jan 10, 2024
@asmorkalov asmorkalov requested review from vpisarev and removed request for asmorkalov January 23, 2024 12:41
@vpisarev
Copy link
Copy Markdown
Contributor

vpisarev commented Jan 26, 2024

that's little but nice clarification of how border mode affects behaviour of functions. It can be merged

@asmorkalov asmorkalov added this to the 4.10.0 milestone Jan 26, 2024
@asmorkalov asmorkalov merged commit ae21368 into opencv:4.x Jan 26, 2024
This was referenced Feb 3, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov left review comments

@vpisarev vpisarev vpisarev approved these changes

Assignees

@vpisarev vpisarev

Labels

category: documentation Documentation fix or update

Projects

None yet

Milestone

4.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@AryanNanda17 @vpisarev @asmorkalov @opencv-alalek