fix highgui qt's statusbar text got cropped#24823
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Jan 9, 2024
Merged
Conversation
asmorkalov
approved these changes
Jan 9, 2024
Contributor
asmorkalov
left a comment
There was a problem hiding this comment.
👍 Tested manually with Ubuntu 18.04.
4 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to fix highgui's statusbar got cropped.
However, none of my fixes by adjusting heights take any effect, and it reveals a deeper and actual problem.
The
QBoxLayout myGlobalLayout -> addWidget's 2nd parameter isstretchrather thanalignment, so the old code does nothing, and the layout does not work.https://doc.qt.io/qt-6/qboxlayout.html#addWidget
myStatusBar->setFixedHeight(20);is a ad-hoc fix becuase when adding the statusbar, the author did not realize that the layout was not working.;Since the layout is fixed, setting a fixed height is no longer needed (both statusbar & qlabel's default height is reasonably small, roughly text height).
After:
The statusbar text looks perfect now.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.