Skip to content

Added test for YOLO NAS#24809

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
Abdurrahheem:ash/yolo-nas-test
Jan 17, 2024
Merged

Added test for YOLO NAS#24809
asmorkalov merged 1 commit intoopencv:4.xfrom
Abdurrahheem:ash/yolo-nas-test

Conversation

@Abdurrahheem
Copy link
Copy Markdown
Contributor

@Abdurrahheem Abdurrahheem commented Jan 3, 2024 •
edited by asmorkalov
Loading

This PR introduces a test for YOLO-NAS model.

Related PR in OpenCV Extra: opencv/opencv_extra#1141
Reference to the GitHub repository used for converting model to ONNX

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@Abdurrahheem Abdurrahheem added the category:dnn_timvx TIM-VX related issues in DNN module label Jan 3, 2024
@Abdurrahheem Abdurrahheem self-assigned this Jan 3, 2024
@Abdurrahheem Abdurrahheem marked this pull request as ready for review January 3, 2024 09:46
fengyuentau
fengyuentau reviewed Jan 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@fengyuentau fengyuentau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide links to the yolo-nas repo? I propose to add reference links as comments in the code to every yolo version if possible.

@fengyuentau
Copy link
Copy Markdown
Member

fengyuentau commented Jan 4, 2024

Also please submit a PR to opencv_extra to add yolo-nas model.

@Abdurrahheem Abdurrahheem mentioned this pull request Jan 9, 2024
Closed
@asmorkalov asmorkalov added category: dnn (onnx) ONNX suport issues in DNN module test and removed category:dnn_timvx TIM-VX related issues in DNN module labels Jan 9, 2024
@asmorkalov asmorkalov added this to the 4.10.0 milestone Jan 9, 2024
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jan 9, 2024

@opencv-alalek Please update test data on BuildBot.

@Abdurrahheem Abdurrahheem mentioned this pull request Jan 9, 2024
Merged
opencv-alalek
opencv-alalek reviewed Jan 9, 2024
View reviewed changes
@asmorkalov asmorkalov mentioned this pull request Jan 15, 2024
Closed
4 tasks
@asmorkalov asmorkalov changed the title Added support for yolo nas test Added test for YOLO NAS Jan 16, 2024
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jan 16, 2024

@Abdurrahheem I rebased your PR on top of 4.x to include Concat fix.

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jan 17, 2024

@fengyuentau @dkurt Could you take a look again. I fixed memory access issue reported by @opencv-alalek and added required references.

asmorkalov
asmorkalov approved these changes Jan 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@opencv-alalek opencv-alalek removed their request for review January 17, 2024 11:42
@asmorkalov asmorkalov merged commit d1e4bd8 into opencv:4.x Jan 17, 2024
@asmorkalov asmorkalov mentioned this pull request Jan 23, 2024
Merged
@asmorkalov asmorkalov mentioned this pull request Feb 7, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fengyuentau fengyuentau fengyuentau left review comments

@opencv-alalek opencv-alalek opencv-alalek left review comments

@asmorkalov asmorkalov asmorkalov approved these changes

@dkurt dkurt dkurt approved these changes

Assignees

@Abdurrahheem Abdurrahheem

Labels

category: dnn (onnx) ONNX suport issues in DNN module test

Projects

None yet

Milestone

4.10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Abdurrahheem @fengyuentau @asmorkalov @dkurt @opencv-alalek