Skip to content

Improve contours approximations in ChessBoardDetector::generateQuads#24760

Closed
MaximSmolskiy wants to merge 1 commit intoopencv:4.xfrom
MaximSmolskiy:improve-contours-approximations-in-ChessBoardDetector-generateQuads
Closed

Improve contours approximations in ChessBoardDetector::generateQuads#24760
MaximSmolskiy wants to merge 1 commit intoopencv:4.xfrom
MaximSmolskiy:improve-contours-approximations-in-ChessBoardDetector-generateQuads

Conversation

@MaximSmolskiy
Copy link
Copy Markdown
Contributor

Pull Request Readiness Checklist

In average approxPolyDP should be monotonous (greater epsilon - less vertices in approxCurve).
So, idea is to use binary search to get quadrangle as approxCurve - not brute-force.

It is expected that there will be very minor change in quality/accuracy, but there may be noticeable improvement in performance

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@MaximSmolskiy MaximSmolskiy marked this pull request as draft December 31, 2023 13:25
@asmorkalov asmorkalov closed this Mar 5, 2024
@MaximSmolskiy MaximSmolskiy deleted the improve-contours-approximations-in-ChessBoardDetector-generateQuads branch March 5, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants