Skip to content

dnn cann: support more operators for SAM#24756

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
fengyuentau:more_cann_operators
Jun 25, 2025
Merged

dnn cann: support more operators for SAM#24756
asmorkalov merged 1 commit intoopencv:4.xfrom
fengyuentau:more_cann_operators

Conversation

@fengyuentau
Copy link
Copy Markdown
Member

@fengyuentau fengyuentau commented Dec 23, 2023

Superseder of #23550.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@fengyuentau fengyuentau added feature category: dnn category:dnn_cann CANN backend related issues in DNN module labels Dec 23, 2023
@fengyuentau fengyuentau added this to the 4.10.0 milestone Dec 23, 2023
@fengyuentau fengyuentau mentioned this pull request Dec 23, 2023
Closed
11 tasks
@asmorkalov asmorkalov requested review from dkurt and zihaomu December 24, 2023 10:47
@asmorkalov asmorkalov modified the milestones: 4.10.0, 4.11.0 May 16, 2024
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jul 24, 2024

@fengyuentau Is it still relevant? I propose to finalize and merge the PR with current list of layers.

@fengyuentau
Copy link
Copy Markdown
Member Author

fengyuentau commented Jul 24, 2024

@fengyuentau Is it still relevant? I propose to finalize and merge the PR with current list of layers.

Let me pick it up after warpAffine acceleration.

@asmorkalov asmorkalov modified the milestones: 4.11.0, 4.12.0 Dec 19, 2024
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented May 5, 2025

@fengyuentau Friendly reminder.

1 similar comment
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jun 3, 2025

@fengyuentau Friendly reminder.

@asmorkalov asmorkalov modified the milestones: 4.12.0, 4.13.0 Jun 3, 2025
@fengyuentau fengyuentau force-pushed the more_cann_operators branch from 28b8ccf to 77d2a58 Compare June 25, 2025 05:07
@fengyuentau fengyuentau marked this pull request as ready for review June 25, 2025 05:07
@fengyuentau
Copy link
Copy Markdown
Member Author

fengyuentau commented Jun 25, 2025

Manually tested on my host with CANN. Build is successful.

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jun 25, 2025

@fengyuentau Thanks a lot for the update. Are the new layers covered with unit tests? Unfortunately I cannot check the PR, I do not have hardware.

@asmorkalov asmorkalov self-assigned this Jun 25, 2025
@fengyuentau
Copy link
Copy Markdown
Member Author

fengyuentau commented Jun 25, 2025

Are the new layers covered with unit tests?

Yes, they are covered.

@asmorkalov asmorkalov merged commit 91be7d3 into opencv:4.x Jun 25, 2025
27 of 28 checks passed
@asmorkalov asmorkalov modified the milestones: 4.13.0, 4.12.0 Jun 25, 2025
@fengyuentau fengyuentau deleted the more_cann_operators branch June 25, 2025 10:48
@asmorkalov asmorkalov mentioned this pull request Jul 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@dkurt dkurt Awaiting requested review from dkurt

@zihaomu zihaomu Awaiting requested review from zihaomu

Assignees

@asmorkalov asmorkalov

Labels

category:dnn_cann CANN backend related issues in DNN module category: dnn feature

Projects

None yet

Milestone

4.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@fengyuentau @asmorkalov