Enable Android AAR package build with SDK project itself without Python#24752
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Dec 25, 2023
Merged
Enable Android AAR package build with SDK project itself without Python#24752asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov merged 1 commit intoopencv:4.xfrom
Conversation
Contributor
Author
|
@mshabunin @opencv-alalek please take a look. |
opencv-alalek
approved these changes
Dec 25, 2023
Contributor
opencv-alalek
left a comment
There was a problem hiding this comment.
There is lack of instructions how to validate the result.
| @@ -0,0 +1,45 @@ | |||
| #!/bin/bash -e | |||
| SDK_DIR=$1 | |||
Contributor
There was a problem hiding this comment.
${1:?Required OpenCV Android SDK path} ?
|
|
||
| echo "OpenCV Android SDK path: ${SDK_DIR}" | ||
|
|
||
| ANDROID_HOME=${ANDROID_HOME:-${ANDROID_SDK_ROOT:-${ANDROID_SDK?Required ANDROID_HOME/ANDROID_SDK/ANDROID_SDK_ROOT}}} |
Contributor
There was a problem hiding this comment.
Prefer using :? to avoid empty values too.
Details: https://tldp.org/LDP/abs/html/parameter-substitution.html
- Added JavaDoc package build and publishing - Added Source package build and publishing - More metadata for publishing - Disable native samples build with aar, because prefab is not complete yet
1da8e1b to
b59eca2
Compare
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.