Skip to content

[CUDA] Hotfix Scale with 1 parameter#24751

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
dkurt:d.kurtaev/hotfix_cuda_scale
Dec 22, 2023
Merged

[CUDA] Hotfix Scale with 1 parameter#24751
asmorkalov merged 1 commit intoopencv:4.xfrom
dkurt:d.kurtaev/hotfix_cuda_scale

Conversation

@dkurt
Copy link
Copy Markdown
Member

@dkurt dkurt commented Dec 22, 2023 •
edited
Loading

Pull Request Readiness Checklist

caused by #24384

[ RUN      ] Test_Darknet_layers.crop/0, where GetParam() = CUDA/CUDA
unknown file: Failure
C++ exception with description "OpenCV(4.8.0-dev) /home/ci/opencv/modules/dnn/src/layers/../cuda4dnn/primitives/scale_shift.hpp:135: error: (-215:Assertion failed) 0 in function 'operator()'
" thrown in the test body.
[  FAILED  ] Test_Darknet_layers.crop/0, where GetParam() = CUDA/CUDA (4 ms)
[ RUN      ] Test_Darknet_layers.crop/1, where GetParam() = CUDA/CUDA_FP16
unknown file: Failure
C++ exception with description "OpenCV(4.8.0-dev) /home/ci/opencv/modules/dnn/src/layers/../cuda4dnn/primitives/scale_shift.hpp:135: error: (-215:Assertion failed) 0 in function 'operator()'
" thrown in the test body.
[  FAILED  ] Test_Darknet_layers.crop/1, where GetParam() = CUDA/CUDA_FP16 (3 ms)

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@dkurt dkurt force-pushed the d.kurtaev/hotfix_cuda_scale branch from 8753527 to 938bc4d Compare December 22, 2023 12:49
@dkurt dkurt requested a review from asmorkalov December 22, 2023 12:59
@asmorkalov asmorkalov added this to the 4.9.0 milestone Dec 22, 2023
asmorkalov
asmorkalov approved these changes Dec 22, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov self-assigned this Dec 22, 2023
@asmorkalov asmorkalov merged commit f399bdf into opencv:4.x Dec 22, 2023
@dkurt dkurt deleted the d.kurtaev/hotfix_cuda_scale branch December 22, 2023 13:52
@asmorkalov asmorkalov mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

bug category: dnn

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dkurt @asmorkalov