Skip to content

Increate Vit_b test threshold a bit for CUDA FP16.#24747

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/tune_vitb_cuda
Dec 22, 2023
Merged

Increate Vit_b test threshold a bit for CUDA FP16.#24747
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/tune_vitb_cuda

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Dec 22, 2023

Motivation: sporadic test failure like https://github.com/opencv/opencv/actions/runs/7297266682/job/19886377164?pr=24744

[ RUN      ] Test_ONNX_nets.ViT_B_32/1, where GetParam() = CUDA/CUDA_FP16
/home/ci/opencv/modules/dnn/test/test_common.impl.hpp:79: Failure
Expected: (normInf) <= (lInf), actual: 0.05369 vs 0.05
ViTB_32  |ref| = 2.8940291404724121
[  FAILED  ] Test_ONNX_nets.ViT_B_32/1, where GetParam() = CUDA/CUDA_FP16 (1352 ms)

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added test category: gpu/cuda (contrib) OpenCV 4.0+: moved to opencv_contrib category: dnn labels Dec 22, 2023
@asmorkalov asmorkalov added this to the 4.9.0 milestone Dec 22, 2023
@asmorkalov asmorkalov merged commit 953dddd into opencv:4.x Dec 22, 2023
@opencv-alalek opencv-alalek removed their request for review December 22, 2023 18:58
@asmorkalov asmorkalov mentioned this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: dnn category: gpu/cuda (contrib) OpenCV 4.0+: moved to opencv_contrib test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants