Skip to content

Do not install removed toolchain file for Android.#24732

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/android_toolchain_install
Dec 21, 2023
Merged

Do not install removed toolchain file for Android.#24732
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/android_toolchain_install

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Dec 21, 2023 •
edited
Loading

Follow up on #24723

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.9.0 milestone Dec 21, 2023
@mshabunin
Copy link
Copy Markdown
Contributor

mshabunin commented Dec 21, 2023

There are also mentions in the documentation (android_ocl_intro.cmake) and scripts (build_sdk.py, test_cmake_sdk.py, option --force_opencv_toolchain). Perhaps they should be corrected too.

@asmorkalov asmorkalov merged commit 8fc31ee into opencv:4.x Dec 21, 2023
@opencv-alalek opencv-alalek removed their request for review December 21, 2023 13:22
@asmorkalov asmorkalov mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshabunin mshabunin Awaiting requested review from mshabunin

Assignees

No one assigned

Labels

category: build/install platform: android

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@asmorkalov @mshabunin