Skip to content

Link libacl_dvpp_mpi library when building with CANN backend#24720

Closed
MengqingCao wants to merge 1 commit intoopencv:4.xfrom
MengqingCao:cann_dvpp_link
Closed

Link libacl_dvpp_mpi library when building with CANN backend#24720
MengqingCao wants to merge 1 commit intoopencv:4.xfrom
MengqingCao:cann_dvpp_link

Conversation

@MengqingCao
Copy link
Copy Markdown
Contributor

@MengqingCao MengqingCao commented Dec 19, 2023

Ascend NPU is a series of AI processors. hiascend. And Compute Architecture for Neural Network (CANN) is a set of computing architectures that serves NPU and programming.

This commit links the libacl_dvpp_mpi library when building with CANN backend. For implementation, please refer to opencv/opencv_contrib#3608.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • [N/A] There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Dec 19, 2023

@MengqingCao @fengyuentau Is the patch required for existing DNN backend? If no, I propose to postpone it after 4.9.0 release.

@fengyuentau
Copy link
Copy Markdown
Member

fengyuentau commented Dec 21, 2023

@MengqingCao @fengyuentau Is the patch required for existing DNN backend? If no, I propose to postpone it after 4.9.0 release.

Nope. We can do it after release.

fengyuentau
fengyuentau approved these changes Dec 21, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@fengyuentau fengyuentau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are more libraries needed inthe future, I propose to use link_directories to link all those needed.

@MengqingCao
Copy link
Copy Markdown
Contributor Author

MengqingCao commented Dec 21, 2023

@MengqingCao @fengyuentau Is the patch required for existing DNN backend? If no, I propose to postpone it after 4.9.0 release.

That' s fine for me if it will not be too late.

If there are more libraries needed inthe future, I propose to use link_directories to link all those needed.

Agree. It would be better if all libraries could be linked.

@fengyuentau
Copy link
Copy Markdown
Member

fengyuentau commented Dec 21, 2023

That' s fine for me if it will not be too late.

We will make a new release most probably before the end of this month.

@MengqingCao MengqingCao mentioned this pull request Jan 2, 2024
Merged
5 tasks
@MengqingCao
Copy link
Copy Markdown
Contributor Author

MengqingCao commented Jan 2, 2024

Please don't merge this PR, I made a mistake by naming the relevant branch in opencv_contrib the same as this repo. Sorry about that, I'll open a new PR to fix it.

@MengqingCao MengqingCao mentioned this pull request Jan 2, 2024
Merged
5 tasks
@MengqingCao MengqingCao closed this Jan 2, 2024
@MengqingCao MengqingCao reopened this Jan 2, 2024
@MengqingCao MengqingCao closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fengyuentau fengyuentau fengyuentau approved these changes

Assignees

No one assigned

Labels

category: build/install category: dnn category: 3rdparty

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MengqingCao @asmorkalov @fengyuentau @opencv-alalek