Skip to content

SPNG integration warning fixes on Windows#24716

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/spng_warning_fix
Dec 20, 2023
Merged

SPNG integration warning fixes on Windows#24716
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/spng_warning_fix

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Dec 19, 2023 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.9.0 milestone Dec 19, 2023
ocpalo
ocpalo approved these changes Dec 19, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ocpalo ocpalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@asmorkalov asmorkalov force-pushed the as/spng_warning_fix branch 2 times, most recently from 06cc613 to 34d62ac Compare December 19, 2023 12:51
@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Dec 19, 2023

@mshabunin @opencv-alalek Clean Windows build with forced SPNG: https://pullrequest.opencv.org/buildbot/builders/precommit_windows64/builds/103855. I reverted SPNG forcing and the PR is ready for review and merge.

opencv-alalek
opencv-alalek approved these changes Dec 19, 2023
View reviewed changes
@asmorkalov asmorkalov merged commit a61306f into opencv:4.x Dec 20, 2023
@asmorkalov asmorkalov mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opencv-alalek opencv-alalek opencv-alalek approved these changes

@mshabunin mshabunin Awaiting requested review from mshabunin

+1 more reviewer

@ocpalo ocpalo ocpalo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@opencv-alalek opencv-alalek

Labels

category: build/install category: imgcodecs

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@asmorkalov @ocpalo @opencv-alalek @mshabunin