Empty vectors before filling them in ChessBoardDetector::processQuads#24702
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Dec 18, 2023
Merged
Empty vectors before filling them in ChessBoardDetector::processQuads#24702asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov merged 1 commit intoopencv:4.xfrom
Conversation
It seems the port in opencv#11703 lost the initialization.
Contributor
Author
|
@MaximSmolskiy , you seem to have fixed a lot lately in that code, does that make sense? |
asmorkalov
requested changes
Dec 18, 2023
| if (count > 0 || (-count > (int)out_corners.size())) | ||
| { | ||
| // copy corners to output array | ||
| out_corners.clear(); |
Contributor
There was a problem hiding this comment.
There is out_corners.resize(0); at the function beginning (line 1886). M.b. it should be replaced with clear() call and the condition may be reduced.
Contributor
Author
There was a problem hiding this comment.
Right, there is one line 1886 but what if you enter this block (1938 to 1951), fill out_corners and actually fail the condition like 1946?
You then can push_back again in the next loop iteration (from loop at 1899) while out_corners has not been cleared.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems the port in #11703 lost the initialization.
The only breaking tests I have are unfortunately internal and complex.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.