Update 3rdparty libspng to 0.7.4#24689
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Dec 15, 2023
Merged
Conversation
Include three fixes: randy408/libspng@e68ba5d randy408/libspng@6c7c8ce randy408/libspng@c9451ca and three chores: randy408/libspng@d86a11d randy408/libspng@bab9f94 randy408/libspng@fb76800 I have reviewed CMakeLists.txt and I think disabling unused-variable warning is not needed.
Collaborator
|
Hi @asmorkalov , give me a couple days to check these changes. I am happy to help! |
asmorkalov
approved these changes
Dec 15, 2023
Contributor
asmorkalov
left a comment
There was a problem hiding this comment.
👍
Tested manually with Ubuntu and Windows 10.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include three fixes:
randy408/libspng@e68ba5d randy408/libspng@6c7c8ce randy408/libspng@c9451ca
and three chores:
randy408/libspng@d86a11d randy408/libspng@bab9f94 randy408/libspng@fb76800
I have reviewed CMakeLists.txt and I think disabling unused-variable warning is not needed.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.