Skip to content

Fix bug in ChessBoardDetector::cleanFoundConnectedQuads#24659

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
MaximSmolskiy:fix-bug-in-ChessBoardDetector-cleanFoundConnectedQuads
Dec 19, 2023
Merged

Fix bug in ChessBoardDetector::cleanFoundConnectedQuads#24659
asmorkalov merged 1 commit intoopencv:4.xfrom
MaximSmolskiy:fix-bug-in-ChessBoardDetector-cleanFoundConnectedQuads

Conversation

@MaximSmolskiy
Copy link
Copy Markdown
Contributor

Pull Request Readiness Checklist

We already have quad_count decrease in https://github.com/opencv/opencv/blob/4.x/modules/calib3d/src/calibinit.cpp#L1271 . So, we have double decrease each loop iteration and it isn't correct

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link
Copy Markdown
Contributor

@AleksandrPanov AleksandrPanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR was tested with OpenCV synthetic benchmark.

There is no accuracy regressions.
image

👍

@AleksandrPanov AleksandrPanov removed their assignment Dec 12, 2023
@MaximSmolskiy
Copy link
Copy Markdown
Contributor Author

@asmorkalov Can you merge this PR please?

@asmorkalov asmorkalov merged commit 509c1af into opencv:4.x Dec 19, 2023
@MaximSmolskiy MaximSmolskiy deleted the fix-bug-in-ChessBoardDetector-cleanFoundConnectedQuads branch December 19, 2023 13:10
@asmorkalov asmorkalov mentioned this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants