Skip to content

Fix stereoRectify image boundaries again.#24648

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
vrabaud:compilation
Dec 6, 2023
Merged

Fix stereoRectify image boundaries again.#24648
asmorkalov merged 1 commit intoopencv:4.xfrom
vrabaud:compilation

Conversation

@vrabaud
Copy link
Copy Markdown
Contributor

@vrabaud vrabaud commented Dec 5, 2023

This should have been fixed in #24035

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work

Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov self-assigned this Dec 6, 2023
@asmorkalov asmorkalov merged commit 22edfd2 into opencv:4.x Dec 6, 2023
@f-dy
Copy link
Copy Markdown

f-dy commented Jan 9, 2024

@asmorkalov Is this the right fix? Another issue was identified in icvGetRectangles: #24831
This would make this patch unnecessary, because then outer1.width would be 1 pixel larger, and then no need to subtract 1 from the numerator

@asmorkalov asmorkalov added this to the 4.9.0 milestone Jan 9, 2024
@asmorkalov asmorkalov mentioned this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants