Skip to content

Removed info lib handling in OpenCV initialization on Android#24640

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/android_info_lib_cleanup
Dec 8, 2023
Merged

Removed info lib handling in OpenCV initialization on Android#24640
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/android_info_lib_cleanup

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Dec 4, 2023 •
edited
Loading

Fixes #8100

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added platform: android cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) labels Dec 4, 2023
@asmorkalov asmorkalov added this to the 4.9.0 milestone Dec 4, 2023
AleksandrPanov
AleksandrPanov approved these changes Dec 7, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@AleksandrPanov AleksandrPanov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with:
Huawei P20 Pro, EMUI 12.0.0, (Android 10?)

PR is working (android samples were tested).
build opencv with:

cmake -GNinja -DCMAKE_TOOLCHAIN_FILE=/home/alexander/Android/Sdk/ndk/18.1.5063045/build/cmake/android.toolchain.cmake -DANDROID_STL=c++_shared -DANDROID_NATIVE_API_LEVEL=21 -DANDROID_SDK=/home/alexander/Android/Sdk/ -DANDROID_NDK=/home/alexander/Android/Sdk/ndk/18.1.5063045/ -DANDROID_HOME=/home/alexander/Android/Sdk/ -DBUILD_ANDROID_EXAMPLES=TRUE -DINSTALL_ANDROID_EXAMPLES=TRUE ..

ninja

👍

@asmorkalov asmorkalov merged commit 1cfd5ac into opencv:4.x Dec 8, 2023
@asmorkalov asmorkalov mentioned this pull request Dec 12, 2023
Closed
@asmorkalov asmorkalov mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AleksandrPanov AleksandrPanov AleksandrPanov approved these changes

@mshabunin mshabunin Awaiting requested review from mshabunin

Assignees

No one assigned

Labels

cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) platform: android

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

Android tries to load nonexisting opencv_info library.

2 participants

@asmorkalov @AleksandrPanov