dnn onnx: add group norm layer#24610
Merged
asmorkalov merged 13 commits intoopencv:4.xfrom Jan 12, 2024
Merged
Conversation
fengyuentau
reviewed
Nov 29, 2023
Member
fengyuentau
left a comment
There was a problem hiding this comment.
Please add tests to test your code:
- Make your test data and model. You can use the existing ONNX models and input data, but you should regenerate the outputs since their implementation is wrong.
- Fork opencv_extra, make a branch with the same branch name
dnn-onnx-add-group-norm-layer, upload the models and data to the branch and submit a PR to opencv_extra. Models should be put to$opencv_extra/testdata/dnn/onnx/conformance/node. Make sure you regenerate the ouput data files. Example: opencv/opencv_extra#1122. - Add tests in
modules/dnn/test/test_onnx_conformance.cpp. Example can be found here: https://github.com/opencv/opencv/pull/24544/files#diff-e5218dd7d4983b99874acb663bf3a849fca73572ae2d6da8083db8d08ee1433f.
Member
|
Also you need to check the item: "I agree to contribute to the project under Apache 2 License." |
dkurt
reviewed
Nov 30, 2023
dkurt
reviewed
Nov 30, 2023
Contributor
|
@fengyuentau @dkurt What are the next steps here? |
Member
Seems like this PR cannot catch the release. Let me review this. |
fengyuentau
reviewed
Dec 21, 2023
Member
fengyuentau
left a comment
There was a problem hiding this comment.
Please resolve merge conflicts with the following commands:
git remote add upstream https://github.com/opencv/opencv
git fetch upstream
git rebase upstream/4.x
# Solve merge conflicts with your editor
git rebase --continue
git push -f
add group normalization impl
add testcases;revise group norm layer in response to [ONNX Issue #5466](onnx/onnx#5466)
01090ae to
a321dac
Compare
fengyuentau
reviewed
Dec 21, 2023
dkurt
reviewed
Dec 22, 2023
fengyuentau
approved these changes
Dec 27, 2023
dkurt
reviewed
Dec 29, 2023
| {"test_gridsample_reflection_padding", 2, 1}, | ||
| {"test_gridsample_zeros_padding", 2, 1}, | ||
| {"test_group_normalization_epsilon", 3, 1}, | ||
| {"test_group_normalization_example", 3, 1}, |
Member
There was a problem hiding this comment.
Contributor
|
@jimmylaw21 Friendly reminder. |
dkurt
approved these changes
Jan 12, 2024
Contributor
|
@jimmylaw21 Thanks a lot for the contribution! Feel free to create a new PR for CANN support too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dnn onnx: add group norm layer
Todo:
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.