Skip to content

Drop OpenCV Manager from samples initialization#24575

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/drop_android_engine
Nov 24, 2023
Merged

Drop OpenCV Manager from samples initialization#24575
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/drop_android_engine

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Nov 22, 2023 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added platform: android cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) labels Nov 22, 2023
@asmorkalov asmorkalov changed the title WIP: Drop OpenCV Manager from samples initialization Drop OpenCV Manager from samples initialization Nov 22, 2023
@asmorkalov asmorkalov force-pushed the as/drop_android_engine branch from e18d03d to e305ccd Compare November 23, 2023 12:29
@asmorkalov asmorkalov added this to the 4.9.0 milestone Nov 23, 2023
@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Nov 23, 2023

@opencv-alalek @mshabunin please review.

@asmorkalov asmorkalov force-pushed the as/drop_android_engine branch 2 times, most recently from 17e1ad2 to 91eee41 Compare November 23, 2023 14:56
@asmorkalov asmorkalov force-pushed the as/drop_android_engine branch from 91eee41 to 2830551 Compare November 23, 2023 15:27
opencv-alalek
opencv-alalek approved these changes Nov 24, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@opencv-alalek opencv-alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks good to me.
However no chance to verify that now (no configured Android environment).

AleksandrPanov
AleksandrPanov approved these changes Nov 24, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@AleksandrPanov AleksandrPanov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check PR with this config:
image
no regressions
There is a problem with camera-calibration sample, but it will be reproduced in 4.x

@asmorkalov asmorkalov merged commit e9f3561 into opencv:4.x Nov 24, 2023
@asmorkalov asmorkalov mentioned this pull request Nov 27, 2023
Merged
6 tasks
@asmorkalov asmorkalov mentioned this pull request Dec 12, 2023
Closed
4 tasks
@asmorkalov asmorkalov mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AleksandrPanov AleksandrPanov AleksandrPanov approved these changes

@opencv-alalek opencv-alalek opencv-alalek approved these changes

@mshabunin mshabunin Awaiting requested review from mshabunin

Assignees

@AleksandrPanov AleksandrPanov

Labels

category: build/install category: samples cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) platform: android

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@asmorkalov @AleksandrPanov @opencv-alalek