Skip to content

Print warning, but not throw exceptions in cv::VideoCapture for OpenNI2#24560

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/openni_status
Nov 21, 2023
Merged

Print warning, but not throw exceptions in cv::VideoCapture for OpenNI2#24560
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/openni_status

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Nov 20, 2023 •
edited
Loading

Homogenize cv::VideoCapture behaviour, as it should not throw exceptions for unsupported properties.
Replaces #24549

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.9.0 milestone Nov 20, 2023
@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Nov 20, 2023

@mathbarc could you try it with your camera?

@mshabunin
Copy link
Copy Markdown
Contributor

mshabunin commented Nov 20, 2023

There are several more CV_Error calls in set*GeneratorProperty methods.

@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Nov 20, 2023

@mshabunin done

@asmorkalov asmorkalov requested a review from mshabunin November 20, 2023 12:08
@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Nov 20, 2023

@WanliZhong @fengyuentau Could you try the patch with camera?

@asmorkalov asmorkalov merged commit fba3c94 into opencv:4.x Nov 21, 2023
@opencv-alalek opencv-alalek removed their request for review November 21, 2023 15:50
@asmorkalov asmorkalov mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshabunin mshabunin mshabunin approved these changes

Assignees

@mshabunin mshabunin

Labels

category: videoio(camera)

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@asmorkalov @mshabunin