Skip to content

fix tab arrow issue#24526

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
thewoz:arrow
Nov 13, 2023
Merged

fix tab arrow issue#24526
asmorkalov merged 1 commit intoopencv:4.xfrom
thewoz:arrow

Conversation

@thewoz
Copy link
Copy Markdown
Contributor

@thewoz thewoz commented Nov 11, 2023 •
edited by asmorkalov
Loading

Fixes #13657 and fixes #20215

I test it on macOS and QT 6.6.0

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • [X ] There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Nov 13, 2023

Warning: modules/highgui/src/window_QT.cpp:2547: trailing whitespace.

@asmorkalov asmorkalov self-requested a review November 13, 2023 08:53
@asmorkalov asmorkalov added this to the 4.9.0 milestone Nov 13, 2023
@thewoz @asmorkalov
Update window_QT.cpp
7cd4fc2 
fix tab arrow issue
asmorkalov
asmorkalov approved these changes Nov 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
I pushed for for CI warning.
Tested with QT 5.9.5 (default in Ubuntu 18.04).

@asmorkalov asmorkalov self-assigned this Nov 13, 2023
@asmorkalov asmorkalov merged commit 4c7d773 into opencv:4.x Nov 13, 2023
@thewoz
Copy link
Copy Markdown
Contributor Author

thewoz commented Nov 13, 2023

thanks!

@asmorkalov asmorkalov mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: highgui-gui

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

QT backend: cv::waitKey() and cv::waitKeyEx() do not capture arrow keys once you click on the image or press TAB Tab key disables arrow keys

2 participants

@thewoz @asmorkalov