Skip to content

Link lib_acl_op_compiler when compile with CANN#24488

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
hipudding:npu_support
Nov 9, 2023
Merged

Link lib_acl_op_compiler when compile with CANN#24488
asmorkalov merged 1 commit intoopencv:4.xfrom
hipudding:npu_support

Conversation

@hipudding
Copy link
Copy Markdown
Contributor

@hipudding hipudding commented Nov 3, 2023 •
edited
Loading

Ascend NPU is a series of AI processors.
hiascend.

This commit link lib_acl_op_compiler library when build with CANN backend. For implementation, please refer to opencv_contrib#3552

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • N/A There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@hipudding hipudding mentioned this pull request Nov 3, 2023
Merged
23 tasks
@asmorkalov asmorkalov added this to the 4.9.0 milestone Nov 3, 2023
fengyuentau
fengyuentau approved these changes Nov 3, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@fengyuentau fengyuentau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fengyuentau fengyuentau self-assigned this Nov 3, 2023
@fengyuentau
Copy link
Copy Markdown
Member

fengyuentau commented Nov 3, 2023

Looks like the doc warnings are from the PR in contrib, not this one:

# default
/build/precommit_docs/4.x/opencv_contrib/modules/cannops/include/opencv2/cann_interface.hpp:433: warning: argument 'src' of command @param is not found in the argument list of cv::cann::crop(InputArray _src, const Rect &rect, AscendStream &stream=AscendStream::Null())
/build/precommit_docs/4.x/opencv_contrib/modules/cannops/include/opencv2/cann_interface.hpp:442: warning: The following parameters of cv::cann::crop(InputArray _src, const Rect &rect, AscendStream &stream=AscendStream::Null()) are not documented:

# PR:4.x / docs
File size: 2963005 bytes = 2893 KiB = 2 MiB
Patch size default limit exceeded: 1024 KiB

@hipudding
Copy link
Copy Markdown
Contributor Author

hipudding commented Nov 3, 2023 •
edited
Loading

Looks like the doc warnings are from the PR in contrib, not this one:


# default

/build/precommit_docs/4.x/opencv_contrib/modules/cannops/include/opencv2/cann_interface.hpp:433: warning: argument 'src' of command @param is not found in the argument list of cv::cann::crop(InputArray _src, const Rect &rect, AscendStream &stream=AscendStream::Null())

/build/precommit_docs/4.x/opencv_contrib/modules/cannops/include/opencv2/cann_interface.hpp:442: warning: The following parameters of cv::cann::crop(InputArray _src, const Rect &rect, AscendStream &stream=AscendStream::Null()) are not documented:



# PR:4.x / docs

File size: 2963005 bytes = 2893 KiB = 2 MiB

Patch size default limit exceeded: 1024 KiB

Thanks. These doc warnings already fixed in opencv_contrib repo.

@hipudding
Copy link
Copy Markdown
Contributor Author

hipudding commented Nov 6, 2023 •
edited
Loading

The patch size is over 2MB because of the pictures in tutorials. The pictures has compressed.

@fengyuentau
Copy link
Copy Markdown
Member

fengyuentau commented Nov 8, 2023

Hello @hipudding , please make a dummy commit to re-trigger the build.

@hipudding
Copy link
Copy Markdown
Contributor Author

hipudding commented Nov 8, 2023

Hello @hipudding , please make a dummy commit to re-trigger the build.

Sure.

@hipudding
Copy link
Copy Markdown
Contributor Author

hipudding commented Nov 9, 2023 •
edited
Loading

@asmorkalov This PR is approved and passed all the tests. Is it ready to merge? Thanks.

@asmorkalov asmorkalov merged commit b3791dc into opencv:4.x Nov 9, 2023
@asmorkalov asmorkalov mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fengyuentau fengyuentau fengyuentau approved these changes

Assignees

@fengyuentau fengyuentau

Labels

category: build/install category: dnn platform: other

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@hipudding @fengyuentau @asmorkalov