Skip to content

Reformat USAC tutorial#24465

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
ivashmak:fix_usac_tutorial
Nov 8, 2023
Merged

Reformat USAC tutorial#24465
asmorkalov merged 1 commit intoopencv:4.xfrom
ivashmak:fix_usac_tutorial

Conversation

@ivashmak
Copy link
Copy Markdown
Contributor

@ivashmak ivashmak commented Oct 28, 2023 •
edited by asmorkalov
Loading

Fixes #23404

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders_only=docs

@asmorkalov asmorkalov added the category: documentation Documentation fix or update label Oct 30, 2023
@asmorkalov asmorkalov self-requested a review October 30, 2023 05:53
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Oct 30, 2023

General recommendations:

  • Please merge bib file to doc/opencv.bib and update references. They will be links.
  • Please replace "NEIGH_FLANN_KNN" with just "NEIGH_FLANN_KNN". Doxygen recognizes function names, class names and constants and adds corss-references automatically.

@ivashmak ivashmak closed this Nov 5, 2023
@ivashmak ivashmak reopened this Nov 5, 2023
@asmorkalov asmorkalov added this to the 4.9.0 milestone Nov 7, 2023
asmorkalov
asmorkalov approved these changes Nov 7, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Nov 7, 2023

@opencv-alalek Could you help to resove documentation build warning. I cannot reproduce the issue locally.

@opencv-alalek
Copy link
Copy Markdown
Contributor

opencv-alalek commented Nov 8, 2023

Problem is visible in GHA environment too: https://github.com/opencv/opencv/actions/runs/6763833637/job/18430285450?pr=24465#step:18:365

We could see the raised problem in GHA more clearly if builder doesn't eat errors (many GHA builders have that problem)

@asmorkalov asmorkalov self-assigned this Nov 8, 2023
@asmorkalov asmorkalov merged commit 5b0ad6b into opencv:4.x Nov 8, 2023
@asmorkalov asmorkalov mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: documentation Documentation fix or update

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

extra \ in usac.markdown

3 participants

@ivashmak @asmorkalov @opencv-alalek