Removed invalid reference usage in charuco detector#24354
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Oct 3, 2023
Merged
Removed invalid reference usage in charuco detector#24354asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov merged 1 commit intoopencv:4.xfrom
Conversation
Contributor
Author
|
/cc @vrabaud |
vrabaud
reviewed
Oct 3, 2023
| Mat mIds = markerIds.getMat(); | ||
| Mat chCorners = charucoCorners.getMat(); | ||
| Mat chIds = charucoIds.getMat(); | ||
| const vector<int>& boardIds = board.getIds(); |
Contributor
There was a problem hiding this comment.
getIds() returns a const vector<int>& so this is fine
vrabaud
reviewed
Oct 3, 2023
vrabaud
requested changes
Oct 3, 2023
Contributor
vrabaud
left a comment
There was a problem hiding this comment.
Please also fix the nearestMarkerIdx reference.
vrabaud
reviewed
Oct 3, 2023
50e8a0e to
c497fe0
Compare
Contributor
Author
|
@vrabaud please take a look again. |
vrabaud
approved these changes
Oct 3, 2023
Contributor
vrabaud
left a comment
There was a problem hiding this comment.
Will the API be changed for getNearestMarkerIdx and such at some point to avoid a vector copy? Otherwise, this PR is fine.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address 60ae973#r127863372
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.