Fail Java test suite, execution, if one of test failed.#24342
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Oct 2, 2023
Merged
Fail Java test suite, execution, if one of test failed.#24342asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov merged 1 commit intoopencv:4.xfrom
Conversation
Contributor
|
There is failed workflow run: https://github.com/opencv/opencv/actions/runs/6350558630/job/17250437327?pr=24342 |
1125abc to
2af5815
Compare
opencv-alalek
approved these changes
Oct 1, 2023
| assertTrue(d > 0.0); | ||
| // Bug: https://github.com/opencv/opencv/issues/24348 | ||
| // d = Core.Mahalanobis(line1, line2, covar); | ||
| // assertTrue(d > 0.0); |
Contributor
There was a problem hiding this comment.
It makes sense to disable this check for ARM only.
Contributor
Author
There was a problem hiding this comment.
Thanks a lot for the suggestion! I'm debugging the issue right now and hopefully propose a solution in a couple of days.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CI behaviour. Issue example: #24323
Temporaty disabled Java test because of #24348.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.