Skip to content

Warnings fix on Windows.#24303

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/vittack_warning_fix
Sep 20, 2023
Merged

Warnings fix on Windows.#24303
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/vittack_warning_fix

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Sep 20, 2023 •
edited
Loading

Related: #24201
Warnings: https://pullrequest.opencv.org/buildbot/builders/precommit_windows64/builds/102818/steps/compile%20release/logs/warnings%20%2816%29

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.9.0 milestone Sep 20, 2023
@asmorkalov asmorkalov marked this pull request as ready for review September 20, 2023 10:56
@asmorkalov asmorkalov force-pushed the as/vittack_warning_fix branch from 163dcd5 to a5895c5 Compare September 20, 2023 11:09
@LaurentBerger
Copy link
Copy Markdown
Contributor

LaurentBerger commented Sep 20, 2023

What's about
https://pullrequest.opencv.org/buildbot/builders/precommit_linux64/builds/104634/steps/test_video/logs/tests%20summary?

@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Sep 20, 2023

I asked alalek to upload the model to all hosts on buildbot.

@opencv-alalek
Copy link
Copy Markdown
Contributor

opencv-alalek commented Sep 20, 2023

I asked alalek to upload the model to all hosts on buildbot.

It is already a part of opencv_extra. Extra steps are not needed.
Mistake is in the merged test code (and completely missed CI runs for merged PR)

@asmorkalov asmorkalov force-pushed the as/vittack_warning_fix branch from a5895c5 to 219a342 Compare September 20, 2023 13:55
@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Sep 20, 2023

@opencv-alalek I fixed the issue. The PR is ready for integration.

mshabunin
mshabunin approved these changes Sep 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mshabunin mshabunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @hanliutong (possible calib3d conflicts with refactoring projects)

@asmorkalov asmorkalov merged commit 6295f7d into opencv:4.x Sep 20, 2023
@hanliutong hanliutong mentioned this pull request Sep 21, 2023
Merged
6 tasks
@asmorkalov asmorkalov mentioned this pull request Sep 28, 2023
Merged
@opencv-alalek opencv-alalek removed their request for review December 26, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshabunin mshabunin mshabunin approved these changes

Assignees

No one assigned

Labels

category: build/install

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@asmorkalov @LaurentBerger @opencv-alalek @mshabunin