Skip to content

Update OpenCVFindOpenBLAS.cmake to accomodate alternative lib name#24269

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
FlyinTeller:patch-1
Sep 14, 2023
Merged

Update OpenCVFindOpenBLAS.cmake to accomodate alternative lib name#24269
asmorkalov merged 1 commit intoopencv:4.xfrom
FlyinTeller:patch-1

Conversation

@FlyinTeller
Copy link
Copy Markdown
Contributor

@FlyinTeller FlyinTeller commented Sep 14, 2023 •
edited
Loading

openBLAS windows release calls their library libopenblas which was not recognized before. see #24268

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • [ X] I agree to contribute to the project under Apache 2 License.
  • [ X] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • [ X] The PR is proposed to the proper branch
  • [ X] There is a reference to the original bug report and related work
  • [ not applicable] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • [ not applicable] The feature is well documented and sample code can be built with the project CMake

@FlyinTeller
Update OpenCVFindOpenBLAS.cmake to accomodate alternative lib name
347a1e2 
openBLAS windows release calls their library libopenblas which was not recognized before. see opencv#24268
@asmorkalov asmorkalov added this to the 4.9.0 milestone Sep 14, 2023
asmorkalov
asmorkalov approved these changes Sep 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested manually with MSVC 2022 and latest release 0.3.24.

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Sep 14, 2023

Related issue in OpenBLAS distribution for Windows: OpenMathLib/OpenBLAS#4227

@asmorkalov asmorkalov self-assigned this Sep 14, 2023
@asmorkalov asmorkalov merged commit fa81936 into opencv:4.x Sep 14, 2023
@asmorkalov asmorkalov mentioned this pull request Sep 14, 2023
Closed
@FlyinTeller FlyinTeller deleted the patch-1 branch September 14, 2023 12:00
@asmorkalov asmorkalov mentioned this pull request Sep 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: build/install

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@FlyinTeller @asmorkalov