Skip to content

Added test with V4L CAP_PROP_CONVERT_RGB=false.#24240

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/vl4_convert_rgb
Oct 16, 2023
Merged

Added test with V4L CAP_PROP_CONVERT_RGB=false.#24240
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/vl4_convert_rgb

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Sep 7, 2023 •
edited
Loading

Test for #24180

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.9.0 milestone Sep 7, 2023
@asmorkalov asmorkalov requested a review from mshabunin September 7, 2023 12:03
mshabunin
mshabunin reviewed Sep 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mshabunin mshabunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this test be moved to the test_v4l2.cpp (which uses vivid device)? It also turns CONVERT_BGR off and checks YUYV format, maybe it should also force change image size to match original scenario?

mshabunin
mshabunin reviewed Oct 13, 2023
View reviewed changes
@mshabunin
Copy link
Copy Markdown
Contributor

mshabunin commented Oct 13, 2023

There is a warning on Windows:

C:\build\precommit_windows64\4.x\opencv\modules\videoio\test\test_camera.cpp(241): warning C4244: 'initializing': conversion from 'double' to 'int', possible loss of data [C:\build\precommit_windows64\build\modules\videoio\opencv_test_videoio.vcxproj]

@asmorkalov @mshabunin
Added test with V4L CAP_PROP_CONVERT_RGB=false.
3ebcd94 
Co-authored-by: Maksim Shabunin <maksim.shabunin@gmail.com>
@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Oct 16, 2023

@mshabunin I fixed warning and applied your suggestion. Could you take a look the PR and RISC-V CI failure. Looks like it's not related to the PR.

@asmorkalov asmorkalov requested a review from mshabunin October 16, 2023 09:41
mshabunin
mshabunin approved these changes Oct 16, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mshabunin mshabunin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for failed RISC-V workflows is here: opencv/ci-gha-workflow#116

I think we can ignore CI failures and merge this PR.

@asmorkalov asmorkalov merged commit 2f63c58 into opencv:4.x Oct 16, 2023
@asmorkalov asmorkalov mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshabunin mshabunin mshabunin approved these changes

Assignees

@mshabunin mshabunin

Labels

category: videoio(camera) platform: linux

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@asmorkalov @mshabunin