Skip to content

Increase the test threshold of FastRCNN_vgg166 and FastRCNN_zf when FAST_MATH enable#24221

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
WanliZhong:issue_24016
Sep 5, 2023
Merged

Increase the test threshold of FastRCNN_vgg166 and FastRCNN_zf when FAST_MATH enable#24221
asmorkalov merged 1 commit intoopencv:4.xfrom
WanliZhong:issue_24016

Conversation

@WanliZhong
Copy link
Copy Markdown
Member

@WanliZhong WanliZhong commented Sep 5, 2023

This PR is used to finish #24016 and #24017

When enable the FAST MATH option, the accuracy will drop a little, but the results are still acceptable. So I change the threshold that make test can pass on Ubuntu. The results visualization are below.

FasterRCNN_vgg16

Real Excepted
real vgg excepted vgg

detail

  real score expected score score diff IoU
CAR 0.997029 0.997022 7E-06 0.970774
DOG 0.993107 0.993028 7.9E-05 0.976928
BICYCLE 0.9484 0.949398 0.000998 0.993465

FasterRCNN_zf

Real Excepted
real zf excepted zf

detail

  real score expected score score diff IoU
CAR 0.986261 0.988779 0.002518 0.938888
DOG 0.967198 0.967198 0 0.999996
BICYCLE 0.901209 0.90121 1E-06 0.999997

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov self-assigned this Sep 5, 2023
@asmorkalov asmorkalov added the test label Sep 5, 2023
@asmorkalov asmorkalov added this to the 4.9.0 milestone Sep 5, 2023
asmorkalov
asmorkalov approved these changes Sep 5, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 9eba360 into opencv:4.x Sep 5, 2023
@asmorkalov asmorkalov mentioned this pull request Sep 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: dnn test

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@WanliZhong @asmorkalov