Skip to content

core: arm64: v_round() works with round to nearest, ties to even.#24215

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
Kumataro:fix24213
Sep 4, 2023
Merged

core: arm64: v_round() works with round to nearest, ties to even.#24215
asmorkalov merged 1 commit intoopencv:4.xfrom
Kumataro:fix24213

Conversation

@Kumataro
Copy link
Copy Markdown
Contributor

@Kumataro Kumataro commented Sep 2, 2023

fix #24213

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@opencv-alalek opencv-alalek added this to the 4.9.0 milestone Sep 3, 2023
@opencv-alalek opencv-alalek added the platform: arm ARM boards related issues: RPi, NVIDIA TK/TX, etc label Sep 3, 2023
@asmorkalov asmorkalov self-requested a review September 4, 2023 07:28
asmorkalov
asmorkalov approved these changes Sep 4, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great job! Thanks a lot for the investigation!

The original test pass by some reason on armv7 and fails as expected with armv8. I replaced it with focused HAL test as it was suggested by alalek. The new test always indicates the issue on both armv7 and armv8 architectures.

@asmorkalov asmorkalov self-assigned this Sep 4, 2023
@asmorkalov asmorkalov merged commit 4dd7554 into opencv:4.x Sep 4, 2023
@Kumataro
Copy link
Copy Markdown
Contributor Author

Kumataro commented Sep 4, 2023

Thank you very much for your review and fix test !!

This was referenced Sep 4, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

bug category: core optimization platform: arm ARM boards related issues: RPi, NVIDIA TK/TX, etc test

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

[RFC] rounding rule for cv::divide()

3 participants

@Kumataro @asmorkalov @opencv-alalek