Closed
Conversation
6ccc75c to
29cd88c
Compare
Contributor
|
@LaurentBerger Thanks for the contribution! Could you provide some use-case for the new function? |
Contributor
|
@LaurentBerger Thanks for the patch. The PR was discussed on OpenCV core team meeting and the team decided to reject the patch. Reasons:
|
Contributor
Author
there is this #24158
Yes it is true for imread too |
Contributor
|
@LaurentBerger At first, thank you for all your contributions to this project!
This is just an another example of bad designed function:
So, we need to avoid of repeating of such experience. Adding function which returns "reference" (not a copy) on the data is a problem with bindings. E.g. in Python code use numpy directly instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.