DNN: fix the issue in layer_fuse#24156
Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom Aug 16, 2023
Merged
Conversation
4 tasks
dkurt
approved these changes
Aug 15, 2023
modules/dnn/src/net_impl_fuse.cpp
Outdated
| String operation_text = toLowerCase(nextData->params.get<String>("operation", "sum")); | ||
| CV_LOG_DEBUG(NULL, "DNN/CPU: fusion with NaryEltwise or Eltwise Layer operation is not supported: " | ||
| << nextData->params.get<String>("operation")); | ||
| << operation_text); |
Contributor
There was a problem hiding this comment.
Some compilation modes may ignore CV_LOG_DEBUG statement completely (empty macro).
We should NOT create orphaned variables which are not used (and we don't want to evaluate unused expressions and call functions).
modules/dnn/src/net_impl_fuse.cpp
Outdated
|
|
||
| if (!nextData->params.has("operation") || toLowerCase(nextData->params.get<String>("operation")) != "add") | ||
| { | ||
| String operation_text = toLowerCase(nextData->params.get<String>("operation", "sum")); |
Contributor
There was a problem hiding this comment.
"sum"
Why is sum?
<empty> should be more appropriate.
Member
Author
There was a problem hiding this comment.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue: #24041
relates #22401
Handling when the
operationof theElemtwise layeris missing.nextData->params.get<String>("operation")will fail when theoperationis missing. This patch adds default value for such case.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.