Fixed buffer overrun; removed the last two uses of sprintf#24143
Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom Aug 18, 2023
Merged
Fixed buffer overrun; removed the last two uses of sprintf#24143opencv-pushbot merged 1 commit intoopencv:4.xfrom
opencv-pushbot merged 1 commit intoopencv:4.xfrom
Conversation
modules/core/src/persistence_xml.cpp
Outdated
| { | ||
| ptr = fs->resizeWriteBuffer( ptr, len + 9 ); | ||
| sprintf( ptr, "<!-- %s -->", comment ); | ||
| snprintf( ptr, len + 9, "<!-- %s -->", comment ); |
Contributor
There was a problem hiding this comment.
Looks like it should be + 10 (+ '\0` char).
Including buffer allocation above (it is a bug).
Contributor
Author
There was a problem hiding this comment.
Good catch! Patch updated...
Fixed an off-by-1 buffer resize, the space for the null termination was forgotten. Prefer snprintf, which can never overflow (if given the right size). In one case I cheated and used strcpy, because I cannot figure out the buffer size at that point in the code.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer snprintf, which can never overflow.
In one case I cheated and used strcpy, because I cannot figure out the buffer size at that point in the code.