Conversation
| //! OpenCV is built with Intel OpenVINO or | ||
| //! DNN_BACKEND_OPENCV otherwise. | ||
| DNN_BACKEND_DEFAULT = 0, | ||
| DNN_BACKEND_HALIDE, |
There was a problem hiding this comment.
That probably breaks enum numeration
There was a problem hiding this comment.
Good point. It also breaks compatibility in case people use enum values directrly instead of enums. Let me discuss with other folks.
There was a problem hiding this comment.
I propose to remove it in 5.x, but do not touch 4.x to presume API compatibility.
There was a problem hiding this comment.
@asmorkalov, Just to clarify, do you mean just a enum value.
| @@ -1,988 +0,0 @@ | |||
| // This file is part of OpenCV project. | |||
There was a problem hiding this comment.
Despite the name, this file should not be removed completely because there are single layer tests for other backends. I suggest renaming.
There was a problem hiding this comment.
Need further discussion.
dkurt
left a comment
There was a problem hiding this comment.
Generally I'm fine with removing Halide backend unless we would like to focus on exotic targets such as Hexagon, PowerPC, Qualcomm, OpenGL, Apple Metal or DirectX (see https://github.com/halide/Halide)
Please take a look at the comments above.
If this is a cleanup for OpenCV 5.0 why target branch is 4.x? |
The motivation is cleaning old backends for the release of OpenCV 5.0. Some cleanings start from 4.x and this is one of them. |
|
|
||
| testing::internal::ParamGenerator< tuple<Backend, Target> > dnnBackendsAndTargets( | ||
| bool withInferenceEngine = true, | ||
| bool withHalide = false, |
There was a problem hiding this comment.
Not sure that this is safe to remove intermediate default argument. Maybe it's better to keep for now and add CV_Assert(!withHalide) inside?
|
Closed in favor of #24231. |
🚀 Cleanup for OpenCV 5.0.
Merge with opencv/opencv_extra#1081.
Todo:
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.