Skip to content

Fix fullscreen behavior for macOS#24098

Merged
asmorkalov merged 3 commits intoopencv:4.xfrom
0xMihir:4.x
Sep 4, 2023
Merged

Fix fullscreen behavior for macOS#24098
asmorkalov merged 3 commits intoopencv:4.xfrom
0xMihir:4.x

Conversation

@0xMihir
Copy link
Copy Markdown
Contributor

@0xMihir 0xMihir commented Aug 2, 2023

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

I'm opening this PR to fix #24097. Currently, this isn't ready to merge because there's still an issue that causes the title bar to take 1-2 seconds to hide. If anyone has any idea how to fix that, please let me know.

@0xMihir 0xMihir marked this pull request as ready for review August 7, 2023 00:06
@asmorkalov asmorkalov requested a review from VadimLevin August 9, 2023 10:28
@asmorkalov asmorkalov added this to the 4.9.0 milestone Aug 9, 2023
VadimLevin
VadimLevin reviewed Aug 11, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@VadimLevin VadimLevin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Please clean-up commented debug cout calls before merged.

I don't think that it is possible to get rid of the transition between normal and full-screen modes in macOS.

@0xMihir
Copy link
Copy Markdown
Contributor Author

0xMihir commented Aug 11, 2023

@VadimLevin Should I delete the ones that were already there?

@VadimLevin
Copy link
Copy Markdown
Contributor

VadimLevin commented Aug 14, 2023

@VadimLevin Should I delete the ones that were already there?

Remove newly introduced ones only

@0xMihir
Copy link
Copy Markdown
Contributor Author

0xMihir commented Aug 17, 2023

Hey, I pushed the changes. Let me know if you need anything else before merging.

@asmorkalov asmorkalov merged commit e274e72 into opencv:4.x Sep 4, 2023
@asmorkalov asmorkalov mentioned this pull request Sep 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VadimLevin VadimLevin VadimLevin approved these changes

Assignees

@VadimLevin VadimLevin

Labels

category: highgui-gui platform: ios/osx

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

macOS Fullscreen broken

3 participants

@0xMihir @VadimLevin @asmorkalov