Skip to content

Fixed warnings in videoio module#24087

Merged
opencv-pushbot merged 2 commits intoopencv:4.xfrom
mshabunin:fix-videoio-warnings
Aug 1, 2023
Merged

Fixed warnings in videoio module#24087
opencv-pushbot merged 2 commits intoopencv:4.xfrom
mshabunin:fix-videoio-warnings

Conversation

@mshabunin
Copy link
Copy Markdown
Contributor

@mshabunin mshabunin commented Aug 1, 2023 •
edited by opencv-alalek
Loading

MSVC warrning:

 622>C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\include\algorithm(2650,24): warning C4244: '=': conversion from 'int' to 'char', possible loss of data [C:\build\precommit-contrib_windows64\build\modules\videoio\opencv_test_videoio.vcxproj]

ARMv7 Linux build issue:

/build/4_x_ARMv7-lin/opencv/modules/videoio/src/cap_v4l.cpp: In member function 'bool cv::CvCaptureCAM_V4L::autosetup_capture_mode_v4l2()':
/build/4_x_ARMv7-lin/opencv/modules/videoio/src/cap_v4l.cpp:276:62: error: 'v4l2_fourcc_be' was not declared in this scope
 #define V4L2_PIX_FMT_Y16_BE v4l2_fourcc_be('Y', '1', '6', ' ')
                                                              ^

allow_multiple_commits=1

@mshabunin mshabunin mentioned this pull request Aug 1, 2023
Merged
7 tasks
@mshabunin
Copy link
Copy Markdown
Contributor Author

mshabunin commented Aug 1, 2023 •
edited
Loading

ARMv7 build has failed, but for different reason:

In file included from /build/precommit_armv7/4.x/opencv/modules/python/src2/cv2.cpp:5:0:
/build/precommit_armv7/4.x/opencv/modules/python/src2/cv2.hpp:20:20: fatal error: Python.h: No such file or directory
 #include <Python.h>
                    ^

Related nightly builder: https://pullrequest.opencv.org/buildbot/builders/4_x_ARMv7-lin

MSVC warning seem to be fixed, at least in GitHub Actions builders.

@mshabunin mshabunin mentioned this pull request Aug 1, 2023
Merged
@opencv-alalek opencv-alalek added this to the 4.9.0 milestone Aug 1, 2023
opencv-alalek
opencv-alalek approved these changes Aug 1, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@opencv-alalek opencv-alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@opencv-alalek opencv-alalek self-assigned this Aug 1, 2023
@opencv-pushbot opencv-pushbot merged commit 0883c6a into opencv:4.x Aug 1, 2023
@mshabunin mshabunin deleted the fix-videoio-warnings branch August 2, 2023 08:01
@asmorkalov asmorkalov mentioned this pull request Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opencv-alalek opencv-alalek opencv-alalek approved these changes

Assignees

@opencv-alalek opencv-alalek

Labels

category: build/install category: videoio

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mshabunin @opencv-alalek @opencv-pushbot